[17.0][FIX] dms: Change save_type when migrate to another storage#467
Open
[17.0][FIX] dms: Change save_type when migrate to another storage#467
Conversation
peluko00
changed the title
peluko00
force-pushed
the
17.0-fix-dms
branch
2 times, most recently
from
8fa2542 to
94cfc2a
Compare
victoralmau
suggested changes
Apr 6, 2026
Member
victoralmau
left a comment
victoralmau
left a comment
There was a problem hiding this comment.
IMP, this change isn't appropriate. Currently, the save_type field is set to compute (not store); perhaps it should be store, but in any case, the value shouldn't be defined this way. The proper approach is to set the appropriate value in the compute (_compute_save_type) based on different scenarios and/or add a depends clause if necessary.
To clarify, I have never used this migration action.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When migrating files from one storage to another, their save type needs to change to match the storage's save_type. After that, these files will no longer require migration.
cc https://github.com/APSL 38655
@miquelalzanillas @lbarry-apsl @javierobcn @mpascuall @BernatObrador @ppyczko please review